Modernize tests (part 1 -- more @glimmer/component) - #21581
Merged
Conversation
NullVoxPopuli
changed the title
@glimmer/component)
Contributor
📊 Size reportTarball size — dist/dev No changes
dist/prod No changes
smoke-tests/v2-app-template/dist No changes
smoke-tests/v2-app-hello-world-template/dist No changes
🤖 This report was automatically generated by wyvox/pkg-size |
NullVoxPopuli
marked this pull request as ready for review
August 19, 2026 18:04
kategengler
reviewed
Aug 24, 2026
kategengler
reviewed
Aug 24, 2026
| viteResolverBug(), | ||
| version(), | ||
| ], | ||
| // `@glimmer/component` is published as its own v2 addon and is only built |
Member
There was a problem hiding this comment.
This and the tsconfig feel like unrelated changes?
Contributor
Author
There was a problem hiding this comment.
They are not unrelated. Previously we required glimmer component no be built bufore we can type check
…on_test_test.js Co-authored-by: Katie Gengler <katie@kmg.io>
kategengler
previously approved these changes
Aug 24, 2026
NullVoxPopuli
commented
Aug 24, 2026
kategengler
approved these changes
Aug 24, 2026
kategengler
changed the title
@glimmer/component)@glimmer/component)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our tests presently use a lot of things that are about to be deprecated (unintentional use, and more happenstansial use)