embassy-nxp/adc: Move AdcPin trait implementations into build.rs - #6727
Draft
sanyaswee wants to merge 3 commits into
Draft
embassy-nxp/adc: Move AdcPin trait implementations into build.rs#6727sanyaswee wants to merge 3 commits into
sanyaswee wants to merge 3 commits into
Conversation
eva-cosma
reviewed
Aug 6, 2026
eva-cosma
left a comment
eva-cosma
left a comment
Contributor
There was a problem hiding this comment.
Yhea, looks good. Only need to have the nxp-pac commit merged (left a comment there), double-check it still functions after the merge to nxp-pac, and we'll merge this one as well!
| embedded-hal-02 = { package = "embedded-hal", version = "0.2.6", features = ["unproven"] } | ||
| ## Chip dependencies | ||
| nxp-pac = { version = "0.1.0", optional = true, git = "https://github.com/embassy-rs/nxp-pac", rev = "e93605d8e8686f1853726921d5349ef3ecdea693" } | ||
| nxp-pac = { version = "0.1.0", optional = true, git = "https://github.com/embassy-rs/nxp-pac", rev = "277270550eb614113e05aa61fed170974976d977" } |
Contributor
There was a problem hiding this comment.
You may need to change this hash after your nxp-pac commit is merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the impl_adc_pin macro calls into build.rs, where it is done by parsing the peripheral from the nxp-pac crate. This also depends on this nxp-pac PR, so this one is draft unless the mentioned one gets merged