Skip to content

Fix PWM duty_cycle 0 #6724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhuyi2024 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −4
Open

Fix PWM duty_cycle 0 #6724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions embassy-mcxa/src/ctimer/pwm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,16 +216,20 @@ impl<'d> SinglePwm<'d> {
});

// Configure PWM period
let period = self.pwm.source_freq / u32::from(self.pwm.pwm_freq) - 1;
self.pwm.max_period = period as u16;
// MR uses period_ticks - 1 because the counter includes zero. The duty
// range includes period_ticks so 0% can use an unreachable match value.
let period_ticks = self.pwm.source_freq / u32::from(self.pwm.pwm_freq);
let max_duty = u16::try_from(period_ticks).map_err(|_| PwmError::InvalidDutyCycle)?;
let period_match = period_ticks - 1;
self.pwm.max_period = max_duty;
self.pwm
.info
.regs()
.mr(self.period_ch.number().into())
.write(|w| w.set_match_(period));
.write(|w| w.set_match_(period_match));

// Configure PWM duty cycle
let duty_cycle = ((period + 1) * (100 - u32::from(config.duty_cycle))) / 100;
let duty_cycle = ((period_ticks) * (100 - u32::from(config.duty_cycle))) / 100;
self.pwm.configure_duty_cycle(duty_cycle);

// Start CTimer
Expand Down