Add test coverage for revectorize's multiple-:auto guard - #1820
Merged
polvalente merged 1 commit intoAug 17, 2026
Conversation
Follow-up to elixir-nx#1819's review: Nx.revectorize already validates that at most one :auto appears across target_axes and the :target_shape option (raising a descriptive ArgumentError for all three combinations), but that guard had no test coverage. Pin it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
polvalente
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review note on #1819 about giving
Nx.revectorize's:target_shapea pass for the same multiple-:autoclass.Verified:
revectorizealready validates this — it raises a descriptiveArgumentError("cannot have more than one:autooccurrence between target_axes and the :target_shape option") for all three combinations (two:autos intarget_axes, one in each, two in:target_shape), and the single-:autocases resolve correctly. The vectorizedreshapepath also picks up #1819's guard.That existing guard had no test coverage, though — this adds a test pinning all three raise cases.
🤖 Generated with Claude Code