Accept sub-byte bitstrings in Nx.from_binary - #1817
Merged
polvalente merged 2 commits intoAug 17, 2026
Merged
Conversation
to_binary's docs note that sub-byte types (u2/u4/s2/s4) may yield a bitstring whose bit count is not divisible by 8 — but from_binary's is_binary guard rejected exactly those values, so the documented round trip crashed. The body already measures in bits (bit_size + rem check); the guard becomes is_bitstring. Docs now note the bitstring case, mirroring to_binary's existing info box. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
polvalente
reviewed
Aug 17, 2026
polvalente
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nx.to_binary's docs note that sub-byte types (u2/u4/s2/s4) may yield a bitstring whose bit count is not divisible by 8 — butNx.from_binary'sis_binaryguard rejected exactly those values, so the documented round trip crashed:The function body already measures in bits (
bit_size+ rem check), so the fix is the guard:is_binary→is_bitstring. A doc sentence now notes the bitstring case, mirroringto_binary's existing info box.Regression test: round trip for u2/u4/s2, asserting the intermediate really is a non-binary bitstring.
🤖 Generated with Claude Code