Pass through non-Expr tensors in stop_grad/custom_grad/metadata - #1801
Closed
Chapaman wants to merge 2 commits into
Closed
Pass through non-Expr tensors in stop_grad/custom_grad/metadata#1801Chapaman wants to merge 2 commits into
Chapaman wants to merge 2 commits into
Conversation
BinaryBackend.block/4 re-applies default callbacks on concrete tensors; wrapping those with Expr.metadata leaked traced results on forward.
Tensor-only guards skipped stop_grad({x, y}) and broke vectorized metadata tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ties to Axon elixir-nx/axon#639
Real results were getting tagged as traced tensors when
BinaryBackend.block/4re-ran callbacks that usedcustom_grad/stop_grad/metadataThis PR makes
Expr.metadatapass through non-Expr tensors so those callbacks stay safe on forward.