priority_queue: support storing non-copyable types in collection - #567
Open
kolomenkin wants to merge 1 commit into
Open
priority_queue: support storing non-copyable types in collection#567kolomenkin wants to merge 1 commit into
kolomenkin wants to merge 1 commit into
Conversation
kolomenkin
force-pushed
the
fix_priority_queue
branch
from
March 6, 2025 20:03
5f9ad08 to
0a008bd
Compare
Previously compilation error was generated while trying to add non-copyable item into collection.
kolomenkin
force-pushed
the
fix_priority_queue
branch
from
March 6, 2025 20:05
0a008bd to
5ff0822
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously compilation error was generated while trying to add non-copyable item into
eastl::priority_queuecollection.Side effects: existing code may become faster (even if it was compiled well before this fix). This is expected because complicated values likes
eastl::stringwill start moving instead of copying.