Enable Jets-HF/jets benchmark in GitLab CI - #114
Merged
Conversation
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot
AI
changed the title
Enable Jets-HF/jets benchmark in CI workflow
Enable Jets-HF/jets benchmark in GitLab CI
Aug 28, 2026
Copilot created this pull request from a session on behalf of
wdconinc
August 28, 2026 23:36
View session
wdconinc
marked this pull request as ready for review
August 28, 2026 23:40
Contributor
There was a problem hiding this comment.
Pull request overview
This PR wires the existing Jets-HF/jets benchmark into the GitLab CI pipeline so it runs alongside the other physics benchmarks and contributes to the aggregate summary output.
Changes:
- Added
benchmarks/Jets-HF/jets/config.ymlto the.gitlab-ci.ymlinclude:list so the benchmark’s jobs are instantiated in the pipeline. - Added
jets:resultsto thesummaryjob’sneedsso its artifacts/results are available during the final aggregation step.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This comment was marked as resolved.
This comment was marked as resolved.
- Remove trailing space in .gitlab-ci.yml that caused YAML parsing error - Fix Snakefile copy-paste errors: replace "dis_" with "jets_" in output_prefix, plot_tag, and test_tag - These changes allow the benchmark to compile and run correctly Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Copilot stopped work on behalf of
wdconinc due to an error
August 29, 2026 01:05
Copilot stopped work on behalf of
wdconinc due to an error
August 29, 2026 01:06
Copilot stopped work on behalf of
wdconinc due to an error
August 29, 2026 01:12
This comment was marked as resolved.
This comment was marked as resolved.
- Add #include <TColor.h> for TColor class usage - Add #include <fstream> for std::ifstream usage - These missing headers were causing compilation errors in the jets benchmark Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
- Add #include <TF1.h> for TF1 class usage - Add #include <TStyle.h> for gStyle object usage - These missing headers were causing compilation errors Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
wdconinc
reviewed
Aug 29, 2026
This comment was marked as resolved.
This comment was marked as resolved.
- Change ReconstructedChargedJets.type from TTreeReaderArray<int> to unsigned int
- Change GeneratedChargedJets.type from TTreeReaderArray<int> to unsigned int
- Comment out non-existent ReconstructedChargedParticleLinks branch definitions
- Comment out code that attempts to access non-existent Links branches
- Update Snakefile data paths to use {INDEX} pattern instead of hardcoded .0000.
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
- Add guard check to prevent accessing pdgMCPart with -1 index - Check if elecIndex >= 0 before using it as array index Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
- Add comment clarifying that electron identification is disabled due to unavailable branches - Explain that all jets are analyzed in the "NoElec" histograms since we cannot identify electrons Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
- Add comment explaining that unused variables are placeholders for future use - Document that they are kept for when ReconstructedChargedParticleLinks branches become available Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
wdconinc
reviewed
Aug 29, 2026
The {INDEX} wildcard in input files cannot be determined from output files,
causing a WildcardError. Following the pattern used in benchmarks/Inclusive/dis,
replace the wildcard with the fixed value '0000' to match the actual file naming.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The ReconstructedChargedParticleLinks branches are available since EICrecon commit e078a5009 and are required for electron identification in jet constituents via MC truth matching. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove all NOTEs about missing ReconstructedChargedParticleLinks and restore the full MC truth matching loop for electron identification in jet constituents. Also remove the elecIndex >= 0 guard that was added as a workaround - master branch doesn't have this check. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…cess - Change chargePartIndex from int to unsigned int to match the type of recoPartAssocRec elements and avoid -Wsign-compare warning - Add elecIndex >= 0 check before accessing pdgMCPart[elecIndex] to prevent out-of-bounds access when no matching particle is found Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
wdconinc
force-pushed
the
copilot/enable-jets-benchmark
branch
from
August 29, 2026 21:08
15421b1 to
83f91b4
Compare
Change from R__LOAD_LIBRARY which fails fatally if library is not found, to gSystem->Load which allows the script to continue. This prevents ROOT from aborting when libfmt is not available via the macro preprocessor, but is available at link time. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
wdconinc
force-pushed
the
copilot/enable-jets-benchmark
branch
from
August 29, 2026 21:10
83f91b4 to
7399adc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI pipeline was not including the Jets-HF/jets benchmark, so its jobs were never being scheduled and its results were excluded from the final benchmark summary. The benchmark implementation already existed in the repo; the workflow definition simply never wired it in.
Summary
Changes
benchmarks/Jets-HF/jets/config.ymlto theinclude:list in.gitlab-ci.yml.jets:resultsto thesummaryjobneedslist so the benchmark contributes to the aggregate output.Result