Fix Mistakes from EDM Switchover - #109
Draft
ruse-traveler wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR reaps what was sown in #107: I didn't test the changes locally and didn't catch a smattering of typos. While testing the macro for the Validation WG, I also found out that the version guards are insufficient: the 26.05.0 campaign used the EDM4eic version with
edm4eic::Jetin it, but was still outputting jets asedm4eic::ReconstructedParticle. This PR fixes this by adding an explicit check on whether or not the area branches exist.What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply