Refine particle acceptance criteria for truth seeds - #2940
Open
ShujieL wants to merge 2 commits into
Open
Conversation
Updated particle acceptance criteria to include all generated particles that have been transported in simulation, clarifying the conditions for truth seed production.
for more information, see https://pre-commit.ci
Contributor
Capybara summary for PR 2940
Last updated 2026-09-03T17:41-04:00 03bf9de |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated particle acceptance criteria to include all generated particles that have been transported in simulation, clarifying the conditions for truth seed production.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This change use the simulation status (nonzero if the particle is transported by the simulation) as the only cut to reject mcparticles that have no chance to leave hits. It will accept both primary/secondary beam background and signal particles so it's proper for background studies.
This change makes the code clearer but effectively have NO impact on the actual truth seeding behavior, because the previous "or" cut on generator status of 1 does not add anything in our current simulation setting: all generator status=1 particles are transported. Any observed issue with truth seeding will remain and require separate investigations.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply