Update CALOROCDigiization.cc - #2933
Open
mhkim-anl wants to merge 1 commit into
Open
Conversation
mhkim-anl
requested review from
mariakzurek,
ruse-traveler,
sly2j,
ssedd1123,
veprbl and
wdconinc
September 1, 2026 06:51
mhkim-anl
temporarily deployed
to
github-pages
September 1, 2026 08:35 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Capybara summary for PR 2933
Last updated 2026-09-01T04:35-04:00 58b4125 |
wdconinc
reviewed
Sep 1, 2026
| // Start from i = 1 since amps[idx_upcross] is used to calculate the crossing time. | ||
| // Pulses that never cross toa_thres are skipped. | ||
| std::size_t idx_upcross = 0; | ||
| for (std::size_t i = 1; i < n_amps; i++) { |
Contributor
There was a problem hiding this comment.
Use find_if with lambda predicate.
ruse-traveler
approved these changes
Sep 3, 2026
ruse-traveler
left a comment
ruse-traveler
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix @mhkim-anl! Wouter's suggestion to use find_if is a good one, but beyond that this looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
Based on a more detailed understanding of the CALOROC measurement principle than when this algorithm was initially implemented, the following three points have been updated. Also, more explanations have been added to describe each step.
toa_thres.RawCALOROCHitshould come after thetoa_thresup-crossing.toa_thresandtot_thressystematically.What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply