Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions src/algorithms/tracking/TrackSeeding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -454,17 +454,32 @@ void TrackSeeding::process(const Input& input, const Output& output) const {
candidates.clear();
kdTree.validTuples(bottomOptions, topOptions, spM, nTopSeedConf, candidates);

// Process bottom-low-high and top-low-high combinations
// Combine low-high and high-low z-direction candidates into a single
// createSeedsFromGroup call per middle SP. This mirrors the Orthogonal
// seeder which processes both z-directions in a single filter pass and
// applies maxSeedsPerSpM across all directions combined. Calling
// createSeedsFromGroup twice (once per direction) would apply the limit
// independently, allowing up to twice as many seeds per middle SP.
Comment thread
wdconinc marked this conversation as resolved.
// All bottom candidates (lh + hl) have r < rM, and all top candidates
// have r > rM, so the combined sets are valid inputs to the doublet finders.
thread_local std::vector<Acts::SpacePointIndex2> combinedBottomIndices;
thread_local std::vector<Acts::SpacePointIndex2> combinedTopIndices;
combinedBottomIndices.clear();
combinedBottomIndices.reserve(candidates.bottom_lh_v.size() + candidates.bottom_hl_v.size());
combinedBottomIndices.insert(combinedBottomIndices.end(), candidates.bottom_lh_v.begin(),
candidates.bottom_lh_v.end());
combinedBottomIndices.insert(combinedBottomIndices.end(), candidates.bottom_hl_v.begin(),
candidates.bottom_hl_v.end());
Comment thread
Copilot marked this conversation as resolved.
combinedTopIndices.clear();
combinedTopIndices.insert(combinedTopIndices.end(), candidates.top_lh_v.begin(),
candidates.top_lh_v.end());
combinedTopIndices.insert(combinedTopIndices.end(), candidates.top_hl_v.begin(),
candidates.top_hl_v.end());

Acts::SpacePointContainer2::ConstSubset bottomSps =
spacePoints.subset(candidates.bottom_lh_v).asConst();
spacePoints.subset(combinedBottomIndices).asConst();
Acts::SpacePointContainer2::ConstSubset topSps =
spacePoints.subset(candidates.top_lh_v).asConst();
data.seedFinder->createSeedsFromGroup(seederCache, *data.bottomDoubletFinder,
*data.topDoubletFinder, *data.tripletFinder, seedFilter,
spacePoints, bottomSps, spM, topSps, actsSeeds);

bottomSps = spacePoints.subset(candidates.bottom_hl_v).asConst();
topSps = spacePoints.subset(candidates.top_hl_v).asConst();
spacePoints.subset(combinedTopIndices).asConst();
data.seedFinder->createSeedsFromGroup(seederCache, *data.bottomDoubletFinder,
*data.topDoubletFinder, *data.tripletFinder, seedFilter,
spacePoints, bottomSps, spM, topSps, actsSeeds);
Expand Down
2 changes: 1 addition & 1 deletion src/algorithms/tracking/TrackSeedingConfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ struct TrackSeedingConfig {
};

/// Seeding method to use (auto, seeding2, or orthogonal)
#if Acts_VERSION_MAJOR <= 46
#if Acts_VERSION_MAJOR < 45 || (Acts_VERSION_MAJOR == 45 && Acts_VERSION_MINOR < 3)
SeedingMethod seedingMethod = SeedingMethod::Orthogonal;
#else
SeedingMethod seedingMethod = SeedingMethod::Seeding2;
Expand Down
Loading