Skip to content

fix: expand track seeding default cfg into non-sqrt values #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wdconinc wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −10
Open

fix: expand track seeding default cfg into non-sqrt values #2906

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e96556
fix: expand track seeding default cfg into non-sqrt values
wdconinc Aug 26, 2026
8e4aa4c
fix: use correct value for timeError
wdconinc Sep 4, 2026
007f312
fix: use more correct value for timeError
wdconinc Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions src/algorithms/tracking/TrackSeedingConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,16 +200,12 @@ struct TrackSeedingConfig {
//////////////////////////////////////////////////////////////////////////
/// TRACK PARAMETER ESTIMATION COVARIANCE

float locaError = std::sqrt(1.5) * Acts::UnitConstants::mm;
float locbError = std::sqrt(1.5) * Acts::UnitConstants::mm;
float phiError = std::sqrt(0.02) * Acts::UnitConstants::rad;
float thetaError = std::sqrt(0.002) * Acts::UnitConstants::rad;
float qOverPError = std::sqrt(0.025) / Acts::UnitConstants::GeV;
float timeError =
std::sqrt(0.1 * Acts::UnitConstants::mm / Acts::UnitConstants::ns) * Acts::UnitConstants::ns;
// FIXME timeError is currently set to 0.0183 = 5.5 ns in these units since:
// Acts::UnitConstants::mm = 1
// Acts::UnitConstants::ns = 299.792458
float locaError = 1.225 * Acts::UnitConstants::mm;
float locbError = 1.225 * Acts::UnitConstants::mm;
float phiError = 0.1414 * Acts::UnitConstants::rad;
float thetaError = 0.0447 * Acts::UnitConstants::rad;
float qOverPError = 1. / (6.325 * Acts::UnitConstants::GeV);
float timeError = 0.0183 * Acts::UnitConstants::ns;
};

inline std::istream& operator>>(std::istream& in,
Expand Down
Loading