-
Notifications
You must be signed in to change notification settings - Fork 42
Add track relationship to TaggerTrackerReconstructedParticles #2841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
b1e09f5
62fa86b
b2f7b9e
6daeab1
d111914
34f0e4e
411b4a9
fa7c55b
867df65
1e3af5e
9f44762
61e9709
b0a7493
d57ba38
073ce92
7314897
757d2c5
af5e56c
fe2546f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,10 @@ Helix::Helix(const edm4hep::Vector3f& p, const edm4hep::Vector3f& o, const doubl | |
| Helix::Helix(const edm4eic::ReconstructedParticle& p, const double b_field) { | ||
| const auto& tracks = p.getTracks(); | ||
| for (const auto& trk : tracks) { | ||
| const auto& traj = trk.getTrajectory(); | ||
| const auto& traj = trk.getTrajectory(); | ||
| if (!traj.isAvailable()) { | ||
| continue; | ||
| } | ||
|
Comment on lines
+40
to
+42
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the long-term vision for this? Are we adding the trajectory for far backward tracks and removing this?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll admit I still don't fully understand the layers of tracking objects in the data model. I don't think there is a need to add trajectories and track parameters to the far backwards code. Someone in the future (potentially myself down the line) might refactor to use more centralized acts methods which would presumably create them. The short term need is for attaching an existing time to the output reconstructed particles. A vertex time would be better but will need some extra work.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would this be ok to merge as is and continue the discussion as necessary elsewhere? |
||
| const auto& trkPars = traj.getTrackParameters(); | ||
|
simonge marked this conversation as resolved.
simonge marked this conversation as resolved.
|
||
| for (const auto& par : trkPars) { | ||
| setParameters(par, b_field); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.