Conversation
Yet we're not "giving the answers to the test" by telling them exactly what they're missing.
Previously, if you reasonably had two steps in one line—like if you said "Open browser to localhost:7272"—the check would never pass. Now, instead, we check every line for the criteria.
Before, "Open the browser..." would not have passed this check; now it will.
Previously, if you hadn't checked for the welcome page in your steps, you'd have no hint as to what you were missing. Now, we give you a hint
This allows people to say to "Log in" or to use the "login button"
I found that if you run the script from another folder, things react unexpectedly. So it seems like a good idea to double-check.
TurekBot
force-pushed
the
improve-manual-testing-check
branch
from
March 27, 2023 04:48
d4420ac to
167deb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discussed improving the check a bit in #28.
Previously, myself and other users found that it was difficult to know what we had done wrong.
Intent
I hope that these changes
Test Cases
I've checked it against the following sets of manual steps:
Any feedback is welcome!