[WIP] Functional transitions for Frame models - #866
Closed
sbenthall wants to merge 6 commits into
Closed
Conversation
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#865 is an implementation of Frames ( see #862 #798 ) that, for consistency with the original HARK simulation methods, uses transition methods that drawn from and mutate the model state.
I.e., a transition method will draw values from
self.shocksand assign the new values directly toself.state_now. It will neither take arguments that correspond to the 'input variables', nor return any output.This PR has a (partial) implementation of functional transition methods. These methods would:
The core
FrameAgentTypeclass then does the logic of drawing variable values to and from memory.I see the benefits of functional transitions equations being:
I'd like to run this by others before completing the implementation because:
transition()withingetStates()is an example of how this would work.t -1) version of a state. The currently proposed implementation is entirely arbitrary. However it connects to questions raised by the namespacing of state variables and the future of NARK.