Feature/seas6 sprint - #290
Draft
MircoValentiniECMWF wants to merge 18 commits into
Draft
Conversation
… encode-mtg2 action
…asonal statistics
…ned more investigation
MircoValentiniECMWF
requested review from
dsarmany and
tweska
and removed request for
tweska
August 13, 2026 14:44
tweska
requested changes
Aug 13, 2026
Comment on lines
+429
to
+456
| @@ -429,10 +441,19 @@ void Statistics::emitStatistics(TemporalStatistics& ts, message::Peer source, me | |||
| Here()); | |||
| } | |||
| // Squash means we don't map (already done in previous loop), but extend the timespan | |||
| const auto old_timspan = dm::parseEntry(dm::TIMESPAN, md); | |||
| timespan.set(ts.win().currPointInHours() - ts.win().creationPointInHours()); | |||
| // std::cout << "Squashing statistics for " << dm::parseEntry(dm::PARAM, md).get() << " with operation " | |||
| // << opname << " :: creation=" << ts.cwin().creationPoint() << " :: current=" | |||
| // << ts.win().currPointInHours() << " :: old_timespan=" << old_timspan.get().toHours() | |||
| // << " :: new_timespan=" << timespan.get().toHours() << std::endl; | |||
| dm::dumpEntry(dm::TIMESPAN, timespan, md); | |||
| } | |||
| else { | |||
| // std::cout << "Mapping statistics for " << dm::parseEntry(dm::PARAM, md).get() << " with operation " | |||
| // << opname << " :: CurrentLoop=" << currentLoop << std::endl; | |||
| /// @note: The mapping should not be applied for second loop (I don't know why this is happening here) | |||
| /// paramMapping_.applyMapping(md, opname, !opt_.disableStrictMapping()); | |||
Member
There was a problem hiding this comment.
Please remove commented out code
Comment on lines
+417
to
+426
| if (ts.periodName() == "month" && ts.cwin().creationPoint().date().day() != 1) { | ||
| std::cout << "Skipping first month because it is not a full month :: " << ts.cwin().creationPoint() | ||
| << std::endl; | ||
| return; // Skip the first month if it is not a full month, as discussed with DGOV and scientists | ||
| } | ||
| if (ts.periodName() == "day" && ts.cwin().creationPoint().time().hours() != 1) { | ||
| std::cout << "Skipping first day because it is not a full day :: " << ts.cwin().creationPoint() | ||
| << std::endl; | ||
| return; // Skip the first day if it is not a full day, as discussed with DGOV and scientists | ||
| } |
Member
There was a problem hiding this comment.
Please note that when a simulation ends in the middle of a month/day, the first half month/day will be emitted because it still starts at the start of a month/day.
endPoint also needs to be at the end of the month/day to avoid this.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #290 +/- ##
===========================================
+ Coverage 33.51% 33.52% +0.01%
===========================================
Files 379 379
Lines 42648 42781 +133
Branches 1839 1851 +12
===========================================
+ Hits 14292 14342 +50
- Misses 28356 28439 +83 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A few bugfix/improvements to encode SEAS6 with new encoder
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-290