Add MTG2Encoder key - #529
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #529 +/- ##
========================================
Coverage 88.22% 88.22%
========================================
Files 854 854
Lines 63549 63549
Branches 11290 11290
========================================
Hits 56067 56067
Misses 7482 7482 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sawom666
reviewed
Aug 20, 2026
| alias MTG2Encoder = MTG2Switch; | ||
| } | ||
| else { | ||
| transient MTG2Encoder = 0: read_only; |
Collaborator
Author
There was a problem hiding this comment.
Good point, thanks!
mcocdawc
added a commit
that referenced
this pull request
Aug 22, 2026
The PR had gone mergeable=CONFLICTING, and GitHub does not deliver pull_request events for a PR whose merge ref it cannot compute -- so eccodes had run no CI at all since 2026-08-21 and was contributing nothing to the rollout signal. This unblocks it. develop landed the cross-repo orchestration independently (#530), so .ci/manifest.toml and both generated cross-repo-trigger*.yml files existed on both sides as add/add conflicts. Resolved to this branch's copies, which are strictly ahead of develop's on all three -- they carry the `options` job-name slot, the HPC leg container, and `ctest = true` -- then regenerated and re-checked to confirm the resolution matches what the generator produces. The only content the merge actually brings in is the MTG2Encoder key (#529). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014ZXmNdJJYqZkpBNTycoPdP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new mechanism to indicate when the MTG2 encoder should be used, specifically targeting internal use at ECMWF. The main change is the addition of the
MTG2Encoderfield, which is conditionally set based on thecentrevalue.Contributor Declaration
By opening this pull request, I affirm the following: