Improve using aliases for wekeo-cds source and update docs and tests - #1104
Open
sandorkertesz wants to merge 2 commits into
Open
Improve using aliases for wekeo-cds source and update docs and tests#1104sandorkertesz wants to merge 2 commits into
sandorkertesz wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1104 +/- ##
===========================================
- Coverage 82.27% 82.27% -0.01%
===========================================
Files 239 239
Lines 17025 17018 -7
Branches 823 823
===========================================
- Hits 14007 14001 -6
+ Misses 2771 2770 -1
Partials 247 247 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the
wekeocdssource to deprecation explicit instead of inferred from the alias table.This involves the following changes in
ClassMaker:ALIASESwas{"wekeo-cds": "wekeocds"}, now{"wekeocds": "wekeo-cds"}— the dashed name is canonical andSOURCESis keyed by it.DEPRECATEDset: deprecation. A source can now be deprecated without being an alias.SourceMaker._lookup()method to avoid using/modifying SourceMaker class variables (i.e. global resources)Contributor Declaration
By opening this pull request, I affirm the following: