Skip to content

fix: support ScoreDebug formatting for paths - #376

Closed
umaucher wants to merge 1 commit into
eclipse-score:mainfrom
umaucher:um_fix-scoredebug-path-formatting
Closed

fix: support ScoreDebug formatting for paths#376
umaucher wants to merge 1 commit into
eclipse-score:mainfrom
umaucher:um_fix-scoredebug-path-formatting

Conversation

@umaucher

Copy link
Copy Markdown
Contributor

Summary

  • Convert Path and PathBuf log arguments to logger-compatible owned strings.
  • Preserve {:?} debug formatting semantics for paths.
  • Add an explicit ScoreDebug implementation for JsonBackend.

Validation

  • bazel test --config=per-x86_64-linux --@score_baselibs//score/log_rust:safety_level=asil_b -- //src/rust/rust_kvs:tests
  • bazel build --config=per-x86_64-linux --@score_baselibs//score/log_rust:safety_level=asil_b -- //src/rust/rust_kvs_tool:kvs_tool

Closes #375

@umaucher
umaucher deployed to workflow-approval August 17, 2026 09:12 — with GitHub Actions Active
@umaucher
umaucher deployed to workflow-approval August 17, 2026 09:12 — with GitHub Actions Active
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 303533ab-3087-419f-9c5d-96fe733544a0
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Analyzing: target //:license-check (4 packages loaded)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (73 packages loaded, 10 targets configured)

Analyzing: target //:license-check (90 packages loaded, 10 targets configured)

Analyzing: target //:license-check (90 packages loaded, 10 targets configured)

Analyzing: target //:license-check (149 packages loaded, 3125 targets configured)

Analyzing: target //:license-check (149 packages loaded, 3125 targets configured)

Analyzing: target //:license-check (149 packages loaded, 3125 targets configured)

Analyzing: target //:license-check (163 packages loaded, 6228 targets configured)

Analyzing: target //:license-check (163 packages loaded, 6228 targets configured)

Analyzing: target //:license-check (176 packages loaded, 11384 targets configured)

Analyzing: target //:license-check (177 packages loaded, 11510 targets configured)

INFO: Analyzed target //:license-check (177 packages loaded, 11510 targets configured).
[13 / 17] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 66 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[16 / 17] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 27.754s, Critical Path: 2.00s
INFO: 17 processes: 12 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 17 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@umaucher
umaucher force-pushed the um_fix-scoredebug-path-formatting branch from e837a4b to 067022d Compare August 17, 2026 09:23
@umaucher
umaucher deployed to workflow-approval August 17, 2026 09:24 — with GitHub Actions Active
@umaucher
umaucher deployed to workflow-approval August 17, 2026 09:24 — with GitHub Actions Active
@umaucher
umaucher marked this pull request as ready for review August 17, 2026 09:40
@vinodreddy-g
vinodreddy-g requested a review from arkjedrz August 17, 2026 11:51

@arkjedrz arkjedrz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it required to cast Path and PathBuf to string? .bazelrc for persistency already has build --@score_baselibs//score/log_rust:safety_level=qm, which enables ScoreDebug implementations for those types.

Please also check what's the current state of Path and PathBuf certification. If it's going to be certified then safety_level=qm implementations can be moved into main one in log_rust implementation. If not then persistency should move from using them - replace with strings, with in-repo reimplementation, or even better - a baselibs one.

Once those topics are sorted out I can proceed with a review.

@PandaeDo
PandaeDo deployed to workflow-approval August 17, 2026 12:31 — with GitHub Actions Active
@PandaeDo
PandaeDo deployed to workflow-approval August 17, 2026 12:31 — with GitHub Actions Active
@umaucher
umaucher marked this pull request as draft August 17, 2026 13:08
@umaucher

Copy link
Copy Markdown
Contributor Author

set to draft until #375 is clarified

Convert filesystem paths to logger-compatible strings while preserving debug formatting.

Closes eclipse-score#375
@umaucher
umaucher force-pushed the um_fix-scoredebug-path-formatting branch from b23fe96 to c8dd3c3 Compare August 20, 2026 16:03
@umaucher

Copy link
Copy Markdown
Contributor Author

got obsolete see description in the bug ticket #375

@umaucher umaucher closed this Sep 10, 2026
@umaucher
umaucher deleted the um_fix-scoredebug-path-formatting branch September 10, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ScoreDebug not implemented for Path/&Path, breaking rust_kvs build

3 participants