Skip to content

add compile-time configuration for kvs maximum storage size - #165

Open
atarekra wants to merge 17 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:kvs-compile-time-max-size-support
Open

add compile-time configuration for kvs maximum storage size#165
atarekra wants to merge 17 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:kvs-compile-time-max-size-support

Conversation

@atarekra

@atarekra atarekra commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

This pull request introduces support for specifying the maximum size of the Key-Value Storage (KVS) at compile time, fulfilling the related requirement:

"The Key-Value-Storage shall support specification of its maximum size at compile time."

and resolves #161

@github-actions

github-actions Bot commented Nov 9, 2025

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 38a53d6d-aef9-44b7-a560-01f3762711e0
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (73 packages loaded, 10 targets configured)

Analyzing: target //:license-check (90 packages loaded, 10 targets configured)

Analyzing: target //:license-check (90 packages loaded, 10 targets configured)

Analyzing: target //:license-check (144 packages loaded, 504 targets configured)

Analyzing: target //:license-check (149 packages loaded, 3125 targets configured)

Analyzing: target //:license-check (149 packages loaded, 3125 targets configured)

Analyzing: target //:license-check (149 packages loaded, 3125 targets configured)

Analyzing: target //:license-check (166 packages loaded, 7582 targets configured)

Analyzing: target //:license-check (166 packages loaded, 9321 targets configured)

Analyzing: target //:license-check (176 packages loaded, 11384 targets configured)

INFO: Analyzed target //:license-check (177 packages loaded, 11510 targets configured).
[13 / 17] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 66 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[15 / 17] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 31.878s, Critical Path: 2.27s
INFO: 17 processes: 12 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 17 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

github-actions Bot commented Nov 9, 2025

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@Ahmed-Elsaka-JC

Copy link
Copy Markdown
Contributor

I see the following points :
user will face issue while flush to memory , i would say it would be better to let use know erlier while using set API to return error in case current storage size in ram exceed configured size.

@PandaeDo PandaeDo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please solve all the build errors?

@atarekra

atarekra commented Feb 2, 2026

Copy link
Copy Markdown
Contributor Author

Could you please solve all the build errors?
Solved

@arkjedrz

Copy link
Copy Markdown
Contributor

I see this PR is up to date, but the change should be discussed.

@arkjedrz

Copy link
Copy Markdown
Contributor

Discussed during CFT 12.03.2026 - configuration of this parameter is okay, but the parameter should be init-time configurable.

@atarekra
atarekra force-pushed the kvs-compile-time-max-size-support branch from ec58b4a to 72f9fc0 Compare June 7, 2026 10:07
Comment thread src/cpp/tests/bm_kvs.cpp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't change the file modes of cpp/hpp/BUILD files they should stay 100644

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored

@github-actions

Copy link
Copy Markdown

Thanks for the pull request. This thread has been quiet for 30 days, so we are marking it as stale for now. Please take a quick look and let us know whether it is still up to date, still relevant, needs review, or is ready to merge. Any new activity will remove the stale label automatically. If nothing changes in the next 10 days, we will close it to keep the backlog current.

@github-actions github-actions Bot added the stale label Aug 23, 2026
@atarekra

Copy link
Copy Markdown
Contributor Author

@arkjedrz Pls review

@github-actions github-actions Bot removed the stale label Aug 24, 2026
Comment thread score/kvs/kvs.cpp Outdated
Comment thread score/kvs/kvsbuilder.hpp Outdated
Comment thread score/kvs/kvsbuilder.hpp Outdated
Comment thread score/kvs/kvs.hpp Outdated
Comment thread score/kvs/tests/test_kvs.cpp Outdated
Comment thread score/kvs/tests/test_kvs.cpp Outdated
PandaeDo
PandaeDo previously approved these changes Aug 26, 2026

@PandaeDo PandaeDo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblock from my side because I'll be on vacation. Please continue to solve conflicts

@atarekra

atarekra commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

@arkjedrz Your points have been resolved , Pls review.

Comment thread score/kvs/kvsbuilder.cpp Outdated
Comment thread score/kvs/kvs.cpp Outdated
Signed-off-by: atarekra <ahmed.tarek-ramadan@valeo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

Add compile-time configuration for maximum Key-Value Storage (KVS) size

6 participants