-
Notifications
You must be signed in to change notification settings - Fork 17
add example for auto generated module verification report #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
29c4093
1dd74ec
fda2384
40d6c62
5b639e9
7fe9d97
e03d4b4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -69,7 +69,7 @@ register_toolchains("@llvm_toolchain//:all") | |
|
|
||
| # tooling | ||
| bazel_dep(name = "score_tooling", version = "1.2.0", dev_dependency = True) | ||
| bazel_dep(name = "aspect_rules_lint", version = "1.10.2", dev_dependency = True) | ||
| bazel_dep(name = "aspect_rules_lint", version = "2.3.0", dev_dependency = True) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't know if this should be upgraded in the same PR.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. its a dev dependency, should not be an issue |
||
| bazel_dep(name = "buildifier_prebuilt", version = "8.5.1.2", dev_dependency = True) | ||
|
|
||
| #docs-as-code | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why touch aspect rules?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a warning regards to that... If I made a PR I can fix that together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot which module updated aspect_rules_lint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aspect_rules_lintwas set directly by this template’sMODULE.bazelin1dd74ec(bazel_dep(..., version = "2.3.0")). The resolved lockfile also showsaspect_tools_telemetry0.2.8 requesting 2.3.0; no separate module update caused it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot yeah, but this was done only to resolve a warning. So what other module did the update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was
score_bazel_cpp_toolchains1.0.3. ItsMODULE.bazeldeclaresaspect_rules_lint2.3.0 (alongsidescore_tooling1.1.2), whilescore_tooling1.2.0 itself requests 1.5.3.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its a dev dependency, should not be an issue