Skip to content

Fix: Resolve log bridge FFI stable compiler compatibility - #275

Merged
pawelrutkaq merged 2 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:fix/log-bridge-compiler-compatibility
Sep 7, 2026
Merged

Fix: Resolve log bridge FFI stable compiler compatibility#275
pawelrutkaq merged 2 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:fix/log-bridge-compiler-compatibility

Conversation

@ShoroukRamzy

@ShoroukRamzy ShoroukRamzy commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Unblock eclipse-score/inc_security_crypto#173
Solves eclipse-score/inc_security_crypto#185 and eclipse-score/inc_security_crypto#49

This PR resolves compiler compatibility crashes in ffi.rs when building @score_logging against modern stable Rust toolchains:

  • Explicit Array Sizes: Replaces deprecated placeholder underscores ([0; _]) with explicit numeric sizes (4 and 24) matching the declared struct layouts.
  • Explicit Namespace: Prefixes the from_utf8_unchecked call with the core:: namespace to resolve undeclared module errors.

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 8646a289-2d08-4604-9f3d-1dcfd0cd2067
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 16.235s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@ShoroukRamzy

Copy link
Copy Markdown
Contributor Author

Hi @masc2023 and @OliverHeilwagen, this PR to remove the current logging patch in eclipse-score/inc_security_crypto#49.

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@ShoroukRamzy

Copy link
Copy Markdown
Contributor Author

Hi @pawelrutkaq, Can you please review and merge this if possible? This is needed to unblock this issue eclipse-score/inc_security_crypto#173 Thanks!

@pawelrutkaq pawelrutkaq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoever I wonder how it can block anyone since we MUST use feroceen compiler which has frozen version. I suspect crypt uses wrong compilr setup ?


// Copy data into array.
let mut data = [0; _];
let mut data = [0; 4];

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repeated 4 from Context , we shall use comon const for it at least

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

/// Create storage for `SlotHandle`.
fn default() -> Self {
Self { _private: [0; _] }
Self { _private: [0; 24] }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sam here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@pawelrutkaq

Copy link
Copy Markdown
Contributor

Hi @pawelrutkaq, Can you please review and merge this if possible? This is needed to unblock this issue eclipse-score/inc_security_crypto#173 Thanks!

Next time use slack please, chances i get notification are low ;/

@ShoroukRamzy

Copy link
Copy Markdown
Contributor Author

Hoever I wonder how it can block anyone since we MUST use feroceen compiler which has frozen version. I suspect crypt uses wrong compilr setup ?

Hi @pawelrutkaq , Yes we are using Ferrocene but rustc is used during the bazel loading phase and that's why parsing failed before Ferrorcene to execute in the execution phase of bazel

@ShoroukRamzy

Copy link
Copy Markdown
Contributor Author

Hi @pawelrutkaq, Could you please give me your feedback regarding these changes and help me merge this if possible?

@github-project-automation github-project-automation Bot moved this from Backlog to On Hold in LOG - Logging FT Sep 7, 2026
@ShoroukRamzy
ShoroukRamzy force-pushed the fix/log-bridge-compiler-compatibility branch from 8559ab2 to b4fb2d7 Compare September 7, 2026 11:49
@ShoroukRamzy
ShoroukRamzy deployed to workflow-approval September 7, 2026 11:49 — with GitHub Actions Active
@ShoroukRamzy
ShoroukRamzy deployed to workflow-approval September 7, 2026 11:49 — with GitHub Actions Active
@ShoroukRamzy
ShoroukRamzy deployed to workflow-approval September 7, 2026 11:49 — with GitHub Actions Active
@ShoroukRamzy
ShoroukRamzy deployed to workflow-approval September 7, 2026 11:49 — with GitHub Actions Active
@pawelrutkaq
pawelrutkaq merged commit c8e85fd into eclipse-score:main Sep 7, 2026
23 checks passed
@github-project-automation github-project-automation Bot moved this from On Hold to Done in LOG - Logging FT Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants