Add IdentifierHash::if_exists - #615
Merged
MaciejKaszynski merged 2 commits intoSep 9, 2026
Merged
Conversation
danth
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
September 8, 2026 15:45
danth
requested a deployment
to
workflow-approval
September 8, 2026 15:45 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
danth
requested a deployment
to
workflow-approval
September 8, 2026 15:45 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
danth
force-pushed
the
identifier-hash-if-exists
branch
from
September 8, 2026 15:46
898fa10 to
6b4f869
Compare
danth
requested a deployment
to
workflow-approval
September 8, 2026 15:46 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
danth
requested a deployment
to
workflow-approval
September 8, 2026 15:46 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
danth
force-pushed
the
identifier-hash-if-exists
branch
from
September 8, 2026 15:48
6b4f869 to
f6b6462
Compare
danth
requested a deployment
to
workflow-approval
September 8, 2026 15:48 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
danth
requested a deployment
to
workflow-approval
September 8, 2026 15:48 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
danth
force-pushed
the
identifier-hash-if-exists
branch
from
September 8, 2026 15:49
f6b6462 to
bf71761
Compare
danth
requested a deployment
to
workflow-approval
September 8, 2026 15:49 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
danth
requested a deployment
to
workflow-approval
September 8, 2026 15:49 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
Member
Author
|
Note that the |
MaciejKaszynski
requested changes
Sep 9, 2026
This constructs an identifier hash only if it already exists, which is useful to avoid allocating.
danth
force-pushed
the
identifier-hash-if-exists
branch
from
September 9, 2026 08:16
bf71761 to
2b6f6ea
Compare
MaciejKaszynski
approved these changes
Sep 9, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in LCM - Lifecycle & Health FT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This constructs an identifier hash only if it already exists, which is useful to avoid allocating.
Will be used to address #489 (comment).
I'm submitting this separately because it is not dependent on the other changes in that pull request.