feat: Add integration test framework - #126
Merged
Merged
Conversation
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
Contributor
|
The created documentation from the pull request is available at: docu-html |
This reverts commit 8f84bd0.
| ping_process = bash_process.__enter__() | ||
| assert ping_process is not None, "Failed to start ping process" | ||
| assert ping_process.is_running(), bash_process.get_output().decode() | ||
| assert tcpdump_process.poll() is None, get_output(tcpdump_process) |
Contributor
There was a problem hiding this comment.
i can confirm that this test fails in wsl2
bazel test --config=qemu-integration //tests/integration_test:test_tcpdump --nocache_test_results --test_output=errors
assert tcpdump_process.poll() is None, get_output(tcpdump_process)
E AssertionError:
i have no solution :(
TimofteBogdan1900
approved these changes
Jun 23, 2026
This reverts commit 1dbbc55.
Contributor
Author
|
Prefer to merge #166 before this PR |
Co-authored-by: lurtz <727209+lurtz@users.noreply.github.com> Signed-off-by: lurtz <727209+lurtz@users.noreply.github.com>
This reverts commit d35e4b8.
in CI and one time locally tcpdump failed to capure ICMP messages. Thus use a more defensive approach
lurtz
enabled auto-merge
June 30, 2026 12:27
opajonk
approved these changes
Jun 30, 2026
opajonk
left a comment
There was a problem hiding this comment.
I briefly checked this for what I know. Review by @TimofteBogdan1900 is good for me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need a way to run integration tests and in the best case they are oblivious to the platform they are run on. For that reason the code from communication/quality has been copied, but the sanitizer tests have been excluded.
In contrast to the code from communication, all tests are run using QEMU and Linux and QNX for the simple reason that then network setup is uniform. For supporting Linux a new ITF plugin has been written and the same tests pass using Linux and QNX.
For test stability the decision has been made that per Python test file and bazel target only a single test will be run. Otherwise there might be stale state from previous tests influencing the behavior of the current test.
#19 is similar. It focuses only on QNX and runs two QEMU instances.