test: add golden outputs for docs.bzl scenarios - #804
Open
AlexanderLanin wants to merge 1 commit into
Open
Conversation
AlexanderLanin
requested review from
MaximilianSoerenPollak,
a-zw,
dcalavrezo-qorix and
nradakovic
as code owners
September 4, 2026 19:21
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
Have to understand it a bit more, some questions etc.
But overall it makes sense to me in the most parts.
Once they are answered and I understand it a bit better I think we could look towards merging it.
| @@ -0,0 +1,1403 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
This one is formatted but the other one isn't.
Not sure if that matters or not?
| @@ -0,0 +1,7 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Compatibility findings are not yet on main no? I'm not sure this should be in this PR.
Or do you intent for them to be merged first?
|
|
||
| markers = [ | ||
| "bazel_cached: successful build-only test expected to reuse Bazel actions", | ||
| "bazel_slow: runtime execution or an uncached expected Bazel failure", |
Contributor
There was a problem hiding this comment.
Do not quiet understand this marker?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The public
docs.bzlscenario tests kept many expected outputs encoded as Python assertions. That made the scenarios incomplete and difficult to understand or update.What
_expected/golden files and directories for the positive docs.bzl scenarios.