Add integration test for mw::com add-on configurations - #1030
Open
SebSparrowHawk wants to merge 1 commit into
Open
Add integration test for mw::com add-on configurations#1030SebSparrowHawk wants to merge 1 commit into
SebSparrowHawk wants to merge 1 commit into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
SebSparrowHawk
force-pushed
the
ssp_add_on_configs_int_test
branch
from
August 31, 2026 13:10
a665a4a to
f298cbf
Compare
SebSparrowHawk
marked this pull request as ready for review
August 31, 2026 13:26
SebSparrowHawk
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
August 31, 2026 13:26
Contributor
|
Please fix #1030 (review) |
SebSparrowHawk
force-pushed
the
ssp_add_on_configs_int_test
branch
from
September 4, 2026 12:05
f298cbf to
2994dfd
Compare
This integration tests ensures that after merging two configurations, an existing instance identifer is still valid and can be used for communication. Also new service instances as defined in the add-on configuration can be created.
SebSparrowHawk
force-pushed
the
ssp_add_on_configs_int_test
branch
from
September 4, 2026 14:45
2994dfd to
8480d1c
Compare
LittleHuba
reviewed
Sep 4, 2026
LittleHuba
left a comment
LittleHuba
left a comment
Contributor
There was a problem hiding this comment.
In general this looks good.
I'm finding the test somewhat too simple.
What you currently do is just assign a different identifier to the same service interface.
But the reconfiguration is way more powerful.
What I would like to see are additional tests that:
- Add a previously unknown service interface with deployment
- Do something that would cause problems (like reconfiguring a previously known service instance where we already have a Skeleton/Proxy for
- ...
| ":common_resources", | ||
| ":test_constants", | ||
| "//score/mw/com", | ||
| "//score/mw/com/impl:instance_specifier", |
Contributor
There was a problem hiding this comment.
Please don't depend on impl in integration tests. This adds technical debt.
| ":common_resources", | ||
| ":test_constants", | ||
| "//score/mw/com", | ||
| "//score/mw/com/impl:instance_specifier", |
|
|
||
| // 2nd step: Load add-on configuration and merge into existing configuration | ||
| const auto service_instance_manifest_path = ParseServiceInstanceManifest(argc, argv); | ||
| const auto add_on_load_result = score::mw::com::runtime::InitializeRuntimeAddonConfiguration( |
Contributor
There was a problem hiding this comment.
Late to the party...
That name is a mouth full. I'd love to have something easier. E.g. score::mw::com::runtime::Reconfigure()
Why was that name chosen?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This integration tests ensures that after merging two configurations, an existing instance identifer is still valid and can be used for communication. Also new service instances as defined in the add-on configuration can be created.