Skip to content

use typed-mem feature flag #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
crimson11 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

use typed-mem feature flag #1022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions score/mw/com/impl/bindings/lola/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,10 @@ cc_library(
implementation_deps = [
"//score/mw/com/impl/bindings/lola/tracing:tracing_runtime",
],
local_defines = select({
"@score_baselibs//score/analysis/tracing/generic_trace_library/flags:require_typed_memory": ["REQUIRE_TYPED_MEMORY"],
"//conditions:default": [],
}),
tags = ["FFI"],
visibility = [
"//score/mw/com/impl/bindings/lola/test:__pkg__",
Expand Down
18 changes: 12 additions & 6 deletions score/mw/com/impl/bindings/lola/skeleton_memory_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,13 @@ bool SkeletonMemoryManager::CreateSharedMemoryForData(
}

const auto path = shm_path_builder_.GetDataChannelShmName(lola_instance_id_);
#ifdef REQUIRE_TYPED_MEMORY
// We only use "typed memory", if REQUIRE_TYPED_MEMORY (set by the GTL) and IPC tracing is enabled/configured, which
// we can deduce from register_shm_object_trace_callback being set.
const bool use_typed_memory = register_shm_object_trace_callback.has_value();
#else
constexpr bool use_typed_memory = false;
#endif
const memory::shared::SharedMemoryFactory::UserPermissions user_permissions =
((permissions.empty()) && (!lola_service_instance_deployment.strict_permissions_))
? memory::shared::SharedMemoryFactory::WorldReadable{}
Expand All @@ -720,17 +726,17 @@ bool SkeletonMemoryManager::CreateSharedMemoryForData(
return false;
}
data_storage_path_ = path;
if (register_shm_object_trace_callback.has_value() && memory_resource->IsShmInTypedMemory())
const auto is_tracing_enabled_for_shm_object = register_shm_object_trace_callback.has_value();
const auto is_typed_memory_required_and_successful_allocated =
use_typed_memory && memory_resource->IsShmInTypedMemory();
if (is_tracing_enabled_for_shm_object && (is_typed_memory_required_and_successful_allocated || !use_typed_memory))
{
// only if the memory_resource could be successfully allocated in typed-memory, we call back the
// register_shm_object_trace_callback, because only then the shm-object can be accessed by tracing
// subsystem.
// Since LoLa creates shm-objects on the granularity of whole service-instances (including ALL its service
// elements), we call register_shm_object_trace_callback once and hand over a dummy element name/type!
// Other bindings, which might create shm-objects per service-element would call
// register_shm_object_trace_callback for each service-element and then use their "real" name and type ...
// Suppress "AUTOSAR C++14 A15-4-2" rule finding. This rule states: "I a function is declared to be
// , (true) or (<true condition>), then it shall not exit with an exception"
// Suppress "AUTOSAR C++14 A15-4-2" rule finding. This rule states: "If a function is declared to be
// noexcept, noexcept(true) or noexcept(<true condition>), then it shall not exit with an exception"
// we can't add to score::cpp::callback signature.
// coverity[autosar_cpp14_a15_4_2_violation]
register_shm_object_trace_callback.value()(
Expand Down
Loading