[TASK] Identify and remove obsolete workflows - #224
Conversation
|
@RamakrishnanPK there is a conflict unfortunately which only you can resolve since its a protected branch |
|
did we submit prs to all consumers off thos workflows in score that are not pinned to stable sha? |
|
Yeah, months ago |
There was a problem hiding this comment.
I am not quiet sure where you found that these workflows are obsolete.
They are still being used by repositories.
The template-sync one and the score-pr-checks might be able to be deleted but require further questioning to infrastructure slack channel or mcp_server maintainers.
Edit:
I just saw the issue that this is suppose to fix.
So then this vital piece of information is missing here as well. Is the old check covered by the new on-pr and if so with what mechanism?
Cause if we now for example force repos to have pre-commit I'm unsure if this will be very popular or accepted and they most likely will want to hold on to the old ones.
| @@ -1,131 +0,0 @@ | |||
| # ******************************************************************************* | |||
There was a problem hiding this comment.
This is still used.
https://github.com/search?q=org%3Aeclipse-score+bzlmod-lock-check.yml&type=code
There was a problem hiding this comment.
Potentially can ignore this if it's covered by the new on-pr check, if so please comment where this is the case.
There was a problem hiding this comment.
It's covered:
Check Runs when Command pre-commit .pre-commit-config.yaml exists uvx pre-commit run --all-files Python tests pyproject.toml and uv.lock exist uv run --frozen python -m pytest Bazel format //:format.check target exists bazel test //:format.check Bazel copyright //:copyright.check target exists bazel run //:copyright.check Bzlmod tidy MODULE.bazel.lock exists bazel mod tidy + git diff --exit-code Bzlmod lockfile MODULE.bazel.lock exists bazel mod deps --lockfile_mode=error
from https://github.com/eclipse-score/cicd-workflows/blob/main/.github/workflows/on-pr.md
However several repos run @main 😢
| @@ -1,50 +0,0 @@ | |||
| # ******************************************************************************* | |||
There was a problem hiding this comment.
Also still in use by some repos.
https://github.com/search?q=org%3Aeclipse-score+.github%2Fworkflows%2Fcopyright.yml&type=code
There was a problem hiding this comment.
Potentially can ignore this if it's covered by the new on-pr check, if so please comment where this is the case.
There was a problem hiding this comment.
Check Runs when Command pre-commit .pre-commit-config.yaml exists uvx pre-commit run --all-files Python tests pyproject.toml and uv.lock exist uv run --frozen python -m pytest Bazel format //:format.check target exists bazel test //:format.check Bazel copyright //:copyright.check target exists bazel run //:copyright.check Bzlmod tidy MODULE.bazel.lock exists bazel mod tidy + git diff --exit-code Bzlmod lockfile MODULE.bazel.lock exists bazel mod deps --lockfile_mode=error
from https://github.com/eclipse-score/cicd-workflows/blob/main/.github/workflows/on-pr.md
However several repos run @main 😢
| @@ -1,74 +0,0 @@ | |||
| # ******************************************************************************* | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Potentially can ignore this if it's covered by the new on-pr check, if so please comment where this is the case.
There was a problem hiding this comment.
we need to re-ealuate the purpose of docs-verify 😭
| @@ -1,51 +0,0 @@ | |||
| # ******************************************************************************* | |||
There was a problem hiding this comment.
This one is also still in use by repos:
https://github.com/search?q=org%3Aeclipse-score+.github%2Fworkflows%2Fformat.yml&type=code
There was a problem hiding this comment.
Potentially can ignore this if it's covered by the new on-pr check, if so please comment where this is the case.
There was a problem hiding this comment.
Check Runs when Command pre-commit .pre-commit-config.yaml exists uvx pre-commit run --all-files Python tests pyproject.toml and uv.lock exist uv run --frozen python -m pytest Bazel format //:format.check target exists bazel test //:format.check Bazel copyright //:copyright.check target exists bazel run //:copyright.check Bzlmod tidy MODULE.bazel.lock exists bazel mod tidy + git diff --exit-code Bzlmod lockfile MODULE.bazel.lock exists bazel mod deps --lockfile_mode=error
from https://github.com/eclipse-score/cicd-workflows/blob/main/.github/workflows/on-pr.md
However several repos run @main 😢
|
I'm afraid we need to revisit this PR after eclipse-score/tools#31 |
4 participants
Fixes #218