[GTK4] Show the box of unchecked check menu items - #3584
Merged
akurtakov merged 1 commit intoSep 11, 2026
Merged
Conversation
GTK themes draw the box of a check menu item only once it is checked, showing a bare checkmark otherwise, while radio menu items always show their circle. A CHECK MenuItem that is not selected therefore appears as a blank row on GTK4, with no hint that it is a toggle. Give the check indicator of popover menus a visible outline in SWT's GTK4 theming fixes, so an unchecked check menu item still shows its checkbox. The outline uses currentColor to follow the menu's text color, keeping it correct in both light and dark themes - this file must not carry a hard-coded color (see Device.overrideThemeValues). Assisted-by: Anthropic Claude Code (claude-opus-4-8)
Member
Author
|
Before: After: |
There was a problem hiding this comment.
🟢 Approval recommended
The focused CSS change correctly addresses the visual issue without hard-coded theme colors.
Pull request overview
Adds a GTK4 theming fix so unchecked check menu items retain a visible checkbox outline.
Changes:
- Styles popover-menu check borders using theme-aware
currentColor. - Documents the rationale and color constraint.
File summaries
| File | Description |
|---|---|
swt_theming_fixes_gtk_4_0_0.css |
Adds the GTK4 checkbox outline rule. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GTK themes draw the box of a check menu item only once it is checked, showing a bare checkmark otherwise, while radio menu items always show their circle. A CHECK MenuItem that is not selected therefore appears as a blank row on GTK4, with no hint that it is a toggle.
Give the check indicator of popover menus a visible outline in SWT's GTK4 theming fixes, so an unchecked check menu item still shows its checkbox. The outline uses currentColor to follow the menu's text color, keeping it correct in both light and dark themes - this file must not carry a hard-coded color (see Device.overrideThemeValues).
Assisted-by: Anthropic Claude Code (claude-opus-4-8)