Skip to content

Fix name pulling in loo_compare #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DominiqueMakowski wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix name pulling in loo_compare #611

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/report.compare.loo.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@

# The values in the first row are 0s because the models are ordered from best to worst according to their elpd.
x <- as.data.frame(x)
modnames <- rownames(x)
modnames <- if ("model" %in% colnames(x)) x[["model"]] else rownames(x)

Comment thread
DominiqueMakowski marked this conversation as resolved.
elpd_diff <- x[["elpd_diff"]]
se_elpd_diff <- x[["se_diff"]]
Expand Down Expand Up @@ -131,7 +131,7 @@
text_models <- sprintf(paste0(text_models, "ENP = %.2f)"), enp[-1])
}
} else {
text_models <- sprintf(paste0(text_models, ")"))

Check warning on line 134 in R/report.compare.loo.R

View workflow job for this annotation

GitHub Actions / lint / lint 

file=R/report.compare.loo.R,line=134,col=22,[sprintf_linter] sprintf call can be removed when a single argument is provided.

Check warning on line 134 in R/report.compare.loo.R

View workflow job for this annotation

GitHub Actions / lint-changed-files / lint-changed-files 

file=R/report.compare.loo.R,line=134,col=22,[sprintf_linter] sprintf call can be removed when a single argument is provided.
}
} else {
text_models <- paste0(text_models, ")")
Expand Down
Loading