Skip to content

Prepare CRAN release #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
strengejacke merged 1 commit into from
Sep 2, 2026
Merged

Prepare CRAN release #1252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: parameters
Title: Processing of Model Parameters
Version: 0.29.2.6
Version: 0.29.3
Authors@R:
c(person(given = "Daniel",
family = "Lüdecke",
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# parameters (devel)
# parameters 0.29.3

## Changes

Expand Down
7 changes: 7 additions & 0 deletions tests/testthat/test-standardize_parameters.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
data("iris")
dat <<- iris

Check warning on line 2 in tests/testthat/test-standardize_parameters.R

View workflow job for this annotation

GitHub Actions / lint-changed-files / lint-changed-files 

file=tests/testthat/test-standardize_parameters.R,line=2,col=5,[assignment_linter] Replace <<- by assigning to a specific environment (with assign() or <-) to avoid hard-to-predict behavior.

# simple ------------------------------------------------------------------
test_that("standardize_parameters (simple)", {
Expand Down Expand Up @@ -120,6 +120,13 @@

expect_equal(z_basic.0.80$CI_high, c(0, 0.135, 0.234, 1.073), tolerance = 0.01)

# following test results have slightly changed on Linux
# R Under development (unstable) (2026-08-27 r90452)
# x86_64-pc-linux-gnu
# Thus, we skip them for now

skip_on_cran()

data("mtcars")
m0 <- lm(mpg ~ cyl + factor(am), mtcars)
expect_equal(
Expand Down Expand Up @@ -305,7 +312,7 @@
)

expect_warning(
stdpr1 <- model_parameters(model, standardize = "basic", test = c("pd", "bf")),

Check warning on line 315 in tests/testthat/test-standardize_parameters.R

View workflow job for this annotation

GitHub Actions / lint-changed-files / lint-changed-files 

file=tests/testthat/test-standardize_parameters.R,line=315,col=5,[implicit_assignment_linter] Avoid implicit assignments in function calls. For example, instead of `if (x <- 1L) { ... }`, write `x <- 1L; if (x) { ... }`.
regexp = "Scale-dependent"
)

Expand All @@ -321,7 +328,7 @@
set.seed(1111)
mod <- rstanarm::stan_glm(am ~ hp, data = mtcars, family = binomial(), refresh = 0)

suppressWarnings(pr1 <- model_parameters(mod, standardize = "refit", test = "pd"))

Check warning on line 331 in tests/testthat/test-standardize_parameters.R

View workflow job for this annotation

GitHub Actions / lint-changed-files / lint-changed-files 

file=tests/testthat/test-standardize_parameters.R,line=331,col=20,[implicit_assignment_linter] Avoid implicit assignments in function calls. For example, instead of `if (x <- 1L) { ... }`, write `x <- 1L; if (x) { ... }`.
expect_shape(pr1, nrow = 2L)
expect_equal(pr1$Median, c(-0.42251, -0.58335), tolerance = 0.01)
expect_equal(pr1$pd, c(0.88425, 0.93000), tolerance = 0.01)
Expand Down
Loading