Skip to content

modelsummary's coef_rename doens't work with logical variables - #1240

Merged
strengejacke merged 5 commits into
mainfrom
strengejacke/issue1239
Jul 3, 2026
Merged

modelsummary's coef_rename doens't work with logical variables#1240
strengejacke merged 5 commits into
mainfrom
strengejacke/issue1239

Conversation

@strengejacke

Copy link
Copy Markdown
Member

Fixes #1239

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for logical parameters by updating parameter type detection, name cleaning, and formatting. The review feedback highlights a potential bug where globally stripping "TRUE$" from parameter names could corrupt non-logical parameters ending in "TRUE", suggesting a safer local handling instead. Additionally, an efficiency improvement is recommended to subset the character vector of names directly rather than subsetting the entire data frame when identifying logical columns.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread R/utils_cleaners.R Outdated
Comment thread R/parameters_type.R Outdated
Comment thread R/format_parameters.R
Comment thread R/parameters_type.R Outdated
@strengejacke
strengejacke merged commit 17f3897 into main Jul 3, 2026
10 of 21 checks passed
@strengejacke
strengejacke deleted the strengejacke/issue1239 branch July 3, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modelsummary's coef_rename doens't work with logical variables

1 participant