* fix: pass productID as query param for story/create and bug/create - #3
Open
chendx-github wants to merge 1 commit into
Open
* fix: pass productID as query param for story/create and bug/create#3chendx-github wants to merge 1 commit into
chendx-github wants to merge 1 commit into
Conversation
Zentao server requires productID in URL query string for POST /stories and POST /bugs, but the action definition only declares productID in requestBody.schema, not action.params. This caused buildQuery to never include it in the URL and buildRequestBody to throw E_MISSING_PARAM when callers pass --product=N (without an explicit productID=N). Changes: - override.ts: add productID to action.params and remove it from requestBody.schema so buildQuery moves it to the URL query and buildRequestBody no longer validates it. - resolve.ts: buildQuery falls back to the base key (e.g. product) when a param is named with the ID suffix (e.g. productID) to match the CLI calling convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zentao server requires productID in URL query for POST /stories and POST /bugs, but the action definition only declares it in requestBody.schema. This caused buildQuery to never include it in the URL and buildRequestBody to throw E_MISSING_PARAM when callers pass --product=N.