Fix symlink handling in dir_contains_files - #5236
Open
Flamefire wants to merge 2 commits into
Open
Conversation
When we check a directory that is a symlink to a folder with files or contains such a symlink but no files itself then this function would return False even though there are files reachable through that path. Return True in this case now.
…ursive paths The non-recursive check used `isfile` which the recursive check is missing and hence leads to different results for broken symlinks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we check a directory that is a symlink to a folder with files or contains such a symlink but no files itself then this function would return False even though there are files reachable through that path.
Return True in this case now.
Fix also the handling of broken symlinks:
os.path.isfile(p)returns True ifpis a file or a symlink pointing to a file.os.walkyields symlinks always asfilesso without checking forisfilethere we would have different results for a folder that contains a broken symlink.Uniformly return False now