Support pathlib Paths in mkdir and cleanup - #5233
Open
Flamefire wants to merge 1 commit into
Open
Conversation
Working with `pathlib` is more comfortable than using `os.path` but `mkdir` doesn't support it due to string manipulation done at the end. Converting the argument to a `Path` (no-op if it is already) allows to clean the function up a bit and make it more reliable by using explicit `relative_to` instead of the substring approach.
Flamefire
force-pushed
the
pathlib-mkdir
branch
from
August 10, 2026 12:06
98bfb2c to
03e8f24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working with
pathlibis more comfortable than usingos.pathbutmkdirdoesn't support it due to string manipulation done at the end. Converting the argument to aPath(no-op if it is already) allows to clean the function up a bit and make it more reliable by using explicitrelative_toinstead of the substring approach.