Add join_path_var function - #5228
Open
Flamefire wants to merge 2 commits into
Open
Conversation
`os.pathsep.join` is often used but there might be empty entries. Those should usually be omitted as they can have different semantics than expected. E.g. `$PYTHONPATH` treats those as `$PWD`.
Flamefire
force-pushed
the
join-path-var
branch
from
August 10, 2026 08:00
a532380 to
b97efdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.pathsep.joinis often used but there might be empty entries.Those should usually be omitted as they can have different semantics
than expected. E.g.
$PYTHONPATHtreats those as$PWD.I ran into this because of a build failure in TensorFlow and though this method should best be in framework