Skip to content

Remove superflous check #5227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Flamefire wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove superflous check #5227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions easybuild/framework/easyblock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4382,6 +4382,7 @@ def sanity_check_load_module(self, extension=None, extra_modules=None):
f'Should be: {self.is_extension}, got: {extension}')
del extension # Avoid accidental use

# Don't load any module for extensions
if self.is_extension:
return self.fake_mod_data

Expand All @@ -4390,8 +4391,7 @@ def sanity_check_load_module(self, extension=None, extra_modules=None):
self.log.info("Loading real module for %s %s: %s", self.name, self.version, self.short_mod_name)
self.load_module(extra_modules=extra_modules)
self.sanity_check_module_loaded = True
# only load fake module for non-extensions, and not during dry run
elif not (self.is_extension or self.dry_run):
elif not self.dry_run:
if extra_modules:
self.log.info("Loading extra modules for sanity check: %s", ', '.join(extra_modules))
try:
Expand Down