Skip to content

Fix fake_module dependencies for ExtensionsEasyblock with --sanity-check-only #5182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Crivella wants to merge 3 commits into
base: develop
Choose a base branch
from
+9 −2
Open

Fix fake_module dependencies for ExtensionsEasyblock with --sanity-check-only #5182

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ff374a
Use `self.cfg.dependencies()` instead of `self.toolchain.dependencies`
Crivella Apr 30, 2026
16407b2
Add creation of mock dependencies module files
Crivella Apr 30, 2026
1cef489
Apply suggestion from @Flamefire
Crivella Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion easybuild/framework/easyblock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1461,7 +1461,7 @@ def make_module_dep(self, unload_info=None):
# include load/unload statements for dependencies
deps = []
self.log.debug("List of deps considered to load in generated module: %s", self.toolchain.dependencies)
Comment thread
Crivella marked this conversation as resolved.
Outdated
for dep in self.toolchain.dependencies:
for dep in self.cfg.dependencies():
if dep['build_only']:
self.log.debug("Skipping build dependency %s", dep)
else:
Expand Down
7 changes: 7 additions & 0 deletions test/framework/easyconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,12 @@ def test_extensions_templates(self):
toy_patch = os.path.join(self.test_sourcepath, 'toy', toy_patch_fn)
copy_file(toy_patch, self.test_prefix)

# Creates empty module files for expected dependencies, needed for `load_fake_module`
tmpdir = tempfile.mkdtemp()
for dep_mod_name in ('Python/3.6.6', ):
write_file(os.path.join(tmpdir, dep_mod_name), "#%Module")
os.environ['MODULEPATH'] = tmpdir

os.environ['EASYBUILD_SOURCEPATH'] = self.test_prefix
init_config(build_options={'silent': True})

Expand All @@ -592,6 +598,7 @@ def test_extensions_templates(self):
'homepage = "http://example.com"',
'description = "test easyconfig"',
'toolchain = SYSTEM',
# Needed to resolve %(pymajver)s template in exts_list
'dependencies = [("Python", "3.6.6")]',
# bogus, but useful to check whether this get resolved
'exts_default_options = {"source_urls": [PYPI_SOURCE]}',
Expand Down
Loading