Add test for correct import of other easyblocks - #4182
Open
Flamefire wants to merge 2 commits into
Open
Conversation
Using e.g. `import easybuild.easyblocks.c.cmake` fails when used with `--include-easyblocks[-from-pr]` as that places easyblocks directly in the `easyblocks` folder. Furthermore e.g. `from easybuild.easyblocks.r import rmpi` will not import the `Rmpi` easyblock but fail as it imports rmpi from the `R` easyblock. The new test catches those issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using e.g.
import easybuild.easyblocks.c.cmakefails when used with--include-easyblocks[-from-pr]as that places easyblocks directly inthe
easyblocksfolder.Furthermore e.g.
from easybuild.easyblocks.r import rmpimay notimport the
Rmpieasyblock but fail as it imports rmpi from theReasyblock.The new test catches those issues.
@Crivella This should catch the
from easybuild.easyblocks.j.julia import EB_JULIA_DEPOT_PATH_VAR, EB_JULIA_LOAD_PATH_VARfrom #4146 before it becomes an issue