Repository navigation
feat(api): dial Kubernetes-discovered orchestrators on their pod IP w… - #3772
Closed
superbarne wants to merge 1 commit into
Closed
superbarne wants to merge 1 commit into
superbarne wants to merge 1 commit into
Conversation
…ith K8S_PREFER_POD_IP The API's Kubernetes discovery addressed orchestrator and template-manager pods by status.hostIP, which is right for the reference deploy, where those pods run with host networking and both addresses are the same. An orchestrator that keeps its own network namespace, for example on an edge node behind an overlay that routes pod CIDRs but not node addresses, is then dialed on an address the API cannot reach, and every create times out. kube.NewPodsOnPort already carried a pod-IP wiring that nothing used. The API now builds both planes through it and follows a new K8S_PREFER_POD_IP flag: off keeps the node's address, on dials the pod's. The default is unchanged.
|
We require contributors to sign our Contributor License Agreement, and we don't have @superbarne on file. You can sign our CLA at https://e2b.dev/docs/cla . Once you've signed, post a comment here that says '@cla-bot check' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ith K8S_PREFER_POD_IP
The API's Kubernetes discovery addressed orchestrator and template-manager pods by status.hostIP, which is right for the reference deploy, where those pods run with host networking and both addresses are the same. An orchestrator that keeps its own network namespace, for example on an edge node behind an overlay that routes pod CIDRs but not node addresses, is then dialed on an address the API cannot reach, and every create times out.
kube.NewPodsOnPort already carried a pod-IP wiring that nothing used. The API now builds both planes through it and follows a new K8S_PREFER_POD_IP flag: off keeps the node's address, on dials the pod's. The default is unchanged.