Repository navigation
Conversation
Keep coefficient members local to the current ensemble fit. Verify unique linear solutions, shape changes, retained snapshots and repeated public SINDy fits.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated
fitcalls append new members toEnsembleOptimizer.coef_listfrom previous fits, so aggregation mixes the previous and current training data. For example, fitting three members with coefficient 1 and then three with coefficient 3 produces a median of 2 instead of 3. Changing the number of features or targets can also fail while aggregating incompatible old and new coefficient shapes.Reset the member list at the start of each ensemble reduction. The existing bagging, library selection, aggregation and random-state behavior within the current fit are preserved.
The regressions cover median and custom mean aggregation, changed coefficient shapes, changed member counts with bagging/library/combined ensembles, retained previous member snapshots, and repeated public
SINDy.fitcalls. Full-rank linear systems and zero responses provide independent coefficient references.Local validation on Windows with Python 3.12.13, NumPy 2.2.6, SciPy 1.15.3 and scikit-learn 1.6.1:
pre-commit run --all-filesreports 11 hooks passed. Flake8 7.3.0 fails locally withMemoryErrorin its automatic multiprocessing workers. Supplemental checks use the same installed Flake8, original configuration and complete standard hook file selection, adding--jobs=1; both the before and after checks pass without diagnostics. The original hook failure is retained.The full upstream test matrix, documentation build and ASV benchmarks have not been run locally.