Skip to content

Chomp lines for readline #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
radar wants to merge 1 commit into from
Closed

Chomp lines for readline #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/dry/files/memory_file_system/node.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def readlines
raise NotMemoryFileError, segment unless file?

@content.rewind
@content.readlines
@content.readlines(chomp: true)
end

# Write file contents
Expand Down
2 changes: 1 addition & 1 deletion spec/unit/dry/files/memory_file_system/node_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@
expect(subject.readlines).to eq(["foo"])

subject.write(%w[foo bar])
expect(subject.readlines).to eq(["foo#{newline}", "bar"])
expect(subject.readlines).to eq(["foo", "bar"])
end

it "raises error when not file" do
Expand Down