driver: Allow user to specify the source system, rather than assume a default value - #94
Open
joshanne wants to merge 1 commit into
Open
driver: Allow user to specify the source system, rather than assume a default value#94joshanne wants to merge 1 commit into
joshanne wants to merge 1 commit into
Conversation
joshanne
commented
Mar 25, 2026
| self.data = data | ||
|
|
||
| def io_process(url, bus, target_system, baudrate, tx_queue, rx_queue, exit_queue, parent_pid): | ||
| def io_process(url, bus, source_system, target_system, baudrate, tx_queue, rx_queue, exit_queue, parent_pid): |
Collaborator
Author
There was a problem hiding this comment.
Perhaps this is more correct to append the source system at the end of the argument list for compatibility?
… default value This one has bitten me a few times on systems that have SYSID_MY_GCS (or the new MAV_GCS_SYSID and MAV_GCS_SYSID_HI) parameters configured with enforcement of the ground station in control (ie. SYSID_ENFORCE or MAV_OPTIONS bit#0). This is the pydronecan changes that allow the front-end to configure the source_system as required
joshanne
force-pushed
the
pr/allow-specifying-source-system
branch
from
August 5, 2026 11:04
57da112 to
20d0667
Compare
Collaborator
Author
|
@tridge Can I bump this one for review? GUI Tool requires this change to be able to set the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one has bitten me a few times on systems that have SYSID_MY_GCS (or the new MAV_GCS_SYSID and MAV_GCS_SYSID_HI) parameters configured with enforcement of the ground station in control (ie. SYSID_ENFORCE or MAV_OPTIONS bit#0).
This is the
pydronecanchanges that allow the front-end to configure the source_system as required.Required by: dronecan/gui_tool#108