Skip to content

Defer teardown out of the mechanics parallel-for #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drbergman merged 1 commit into from
Aug 8, 2026
Merged

Defer teardown out of the mechanics parallel-for #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions core/PhysiCell_cell.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1507,12 +1507,13 @@ void Cell::ingest_cell( Cell* pCell_to_eat )

}

// things that have their own thread safety
// Teardown is deferred rather than done here. flag_for_removal() queues this
// cell, and the serial cells_ready_to_die -> die() -> delete_cell() pass does
// the same four steps off-thread. Doing them here means mutating other cells'
// lists from inside the mechanics parallel-for, where remove_all_* walks a
// vector unlocked while attach/detach_cell_as_spring edits it under the
// critical -- a real race, not a theoretical one.
pCell_to_eat->flag_for_removal();
pCell_to_eat->remove_all_attached_cells();
pCell_to_eat->remove_all_attackers();
pCell_to_eat->remove_self_from_attacked();
pCell_to_eat->remove_all_spring_attachments();

return;
}
Expand Down Expand Up @@ -1678,11 +1679,13 @@ void Cell::fuse_cell( Cell* pCell_to_fuse )
}

// things that have their own thread safety
// Teardown is deferred rather than done here. flag_for_removal() queues this
// cell, and the serial cells_ready_to_die -> die() -> delete_cell() pass does
// the same four steps off-thread. Doing them here means mutating other cells'
// lists from inside the mechanics parallel-for, where remove_all_* walks a
// vector unlocked while attach/detach_cell_as_spring edits it under the
// critical -- a real race, not a theoretical one.
pCell_to_fuse->flag_for_removal();
pCell_to_fuse->remove_all_attached_cells();
pCell_to_fuse->remove_all_attackers();
pCell_to_fuse->remove_self_from_attacked();
pCell_to_fuse->remove_all_spring_attachments();

return;
}
Expand Down Expand Up @@ -1712,10 +1715,12 @@ void Cell::lyse_cell( void )

// remove all adhesions

remove_all_attached_cells();
remove_all_attackers();
remove_self_from_attacked();
remove_all_spring_attachments();
// Teardown is deferred rather than done here. flag_for_removal() queues this
// cell, and the serial cells_ready_to_die -> die() -> delete_cell() pass does
// the same four steps off-thread. Doing them here means mutating other cells'
// lists from inside the mechanics parallel-for, where remove_all_* walks a
// vector unlocked while attach/detach_cell_as_spring edits it under the
// critical -- a real race, not a theoretical one.

// set volume to zero
set_total_volume( 0.0 );
Expand Down
Loading