Add OptSolvX adapter, demo, tests, and docs (initial SBSCL integration) - #88
Open
xts-Michi wants to merge 11 commits into
Open
Add OptSolvX adapter, demo, tests, and docs (initial SBSCL integration)#88xts-Michi wants to merge 11 commits into
xts-Michi wants to merge 11 commits into
Conversation
… ctor) and changed the pom OptSolvX verison to java 8
…nds, S·v=0, objective) into OptSolvX
…ective tests using jdk 8 artifact
…e FbaToOptSolvX preview
draeger
approved these changes
Aug 21, 2025
draeger
left a comment
Member
There was a problem hiding this comment.
Please coordinate with Ayush that all tests from the SBML test suite run smoothly, including fbc tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready to merge yet — updated scope below 👇
Summary
Wires SBSCL ↔ OptSolvX via a small solver adapter and adds a first SBML/FBC → LP bridge skeleton. Includes a runnable demo, unit tests, and short docs. No existing code paths are changed; OptSolvX stays Java-8 compatible (jdk8 classifier).
Changes
Adapter
org.simulator.optsolvx.OptSolvXSolverAdapternull+build()), delegates to CommonsMathSolver.SBML/FBC → LP bridge (new)
org.simulator.optsolvx.FbaToOptSolvX(skeleton)vars/cons/objective/dir) to aid debugging.Tests
org.simulator.optsolvx.OptSolvXSolverAdapterTestsolve_requires_non_null_model(IAE)solve_requires_build(ISE)smoke_minimize_with_eq_and_bounds(min 2x+y, x+y=5 → x=0,y=5,obj=5)Bridge tests (new):
org.simulator.optsolvx.BridgeSmokeTestorg.simulator.optsolvx.BridgeObjectiveTestDocs
How to run
Demo (IDE):
org.simulator.optsolvx.OptSolvXDemoTests (Maven):
mvn -q -Dtest=org.simulator.optsolvx.OptSolvXSolverAdapterTest testmvn -q -Dtest=org.simulator.optsolvx.BridgeSmokeTest,org.simulator.optsolvx.BridgeObjectiveTest testmvn -q -Dtest=org.simulator.optsolvx.* testOpen items / Next
FbaToOptSolvXmapping (full stoichiometry constraints, reversible flux handling, edge cases).