WIP: Scaffold Python/Docker CLI architecture for BioSimulators curation (#68) - #106
WIP: Scaffold Python/Docker CLI architecture for BioSimulators curation (#68)#106dyrpsf wants to merge 1 commit into
Conversation
draeger
left a comment
There was a problem hiding this comment.
I did not spot any obvious errors in the implementation, but I am unsure about the project structure. In particular, is biosimulators in the repository root the right location for the biosimulators.org compatibility code, or should this be placed under src instead? I would appreciate the other reviewer’s opinion before approving.
Thank you for the review, @draeger ! I'm really glad the core Py4J and Docker implementation looks solid. I am completely flexible on the project structure. Since these are Python scripts, a Dockerfile, and shell scripts rather than Java source code, I initially placed them in a root I will hold off on making any changes and wait for @matthiaskoenig and @tyzerrr to share their thoughts. Once there is a consensus, I'll update the folder structure immediately! |
Problem
This PR addresses Issue #68, aiming to reach Level 5 curation on BioSimulators, which requires a containerized command-line interface.
Architectural Setup
This Draft PR scaffolds the recommended architecture:
py4jtopom.xmland createdBioSimulatorsGateway.javato act as the Java-side server for the SBSCL engine.biosimulators/main.pyutilizingbiosimulators-utilsto handle SED-ML parsing and interface with the Java Gateway.Dockerfileandentrypoint.shto package the Fat JAR along with its dependencies, initialize the Java server in the background, and expose the Python CLI.Next Steps
main.pyscript needs the specific SED-ML variables mapped to thesbscl_enginevia the Py4J gateway.