Add basic FROG report generation for FBA models - #102
Open
dyrpsf wants to merge 2 commits into
Open
Conversation
draeger
requested changes
Mar 9, 2026
draeger
left a comment
Member
There was a problem hiding this comment.
This looks good! Thanks for implementing this feature in the first version. I agree it should be included, but we should not write JSON code "by hand" as it is done now. Instead, let's include a lightweight JSON library and remove JSON string processing from our code.
Contributor
Author
|
I’ve pushed an update that:
|
draeger
self-requested a review
March 10, 2026 21:20
Contributor
Author
Thank you for the review and feedback! Glad I could contribute. Looking forward to working on more improvements in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for generating FROG reference files for FBA models and addresses #49.
New functionality
Introduces
org.simulator.fba.FrogReportwith a static methodwhich:
reads an SBML FBC model,
runs
FluxBalanceAnalysis,collects the active objective id and objective value,
builds a FROG JSON report following the FROG schema v1 (https://github.com/matthiaskoenig/fbc_curation),
and writes the JSON file.
The generated FROG report currently includes:
metadata: model location, MD5 hash, software/solver/environment info.objectives: a single entry for the active objective with status (optimal/infeasible) and value.fva,reaction_deletions,gene_deletions: present as empty lists as placeholdersTests
Adds
FrogReportTestinsrc/test/java/org/simulator/fba/FrogReportTest.java:e_coli_core.xmlFBC test model,FrogReport.writeFrogReport(...),metadata,objectives,fva,reaction_deletions,gene_deletions).This provides a first step towards FROG support so that SBSCL can produce standardized
reference files for FBA models which can be used together with fbc_curation / runfrog
to check reproducibility across solvers.