Remove C4995 suppression - #11807
Open
mmitche wants to merge 2 commits into
Open
Conversation
Remove the global managed C++ warning suppression so BinSkim no longer reports BA2007 for DirectWriteForwarder. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7718d31d-6d80-41f3-a6d5-b441d4616058
dotnet-policy-service
Bot
added
the
PR
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the global managed C++ suppression for compiler warning C4995 so that /wd4995 is no longer applied broadly (notably to DirectWriteForwarder), aligning with the BinSkim BA2007 mitigation goal referenced in dotnet/dotnet#8042.
Changes:
- Removed C4995 from the
ManagedCxxSuppressionslist used to populate common managed C++ warning disables.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
can probably also remove now that it's no longer /clr:pure and I think /clr:netcore isn't actually deprecated Lines 9 to 13 in 1346571 |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: dc79d0ce-c030-4966-8296-34932c6b46ed
Member
Author
|
@dipeshmsft Can you take a look? |
akoeplinger
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the global managed C++ suppression for warning C4995. This prevents /wd4995 from being applied to DirectWriteForwarder and resolves the BinSkim BA2007 result tracked by dotnet/dotnet#8042.
Validation
Built DirectWriteForwarder in Release for x86, x64, and arm64 with zero warnings and zero errors in the dotnet/dotnet VMR.
Microsoft Reviewers: Open in CodeFlow