Skip to content

Show modified shell in dotnetup to explain modes - #55648

Open
nagilson wants to merge 8 commits into
dotnet:release/dnupfrom
nagilson:nagilson-show-dotnetup-modifications
Open

Show modified shell in dotnetup to explain modes#55648
nagilson wants to merge 8 commits into
dotnet:release/dnupfrom
nagilson:nagilson-show-dotnetup-modifications

Conversation

@nagilson

@nagilson nagilson commented Aug 6, 2026

Copy link
Copy Markdown
Member

While this is not a complete resolution of #53963 (comment), (it does not fix the UX for 'env' commands), it does change the summary walkthrough to be more clear about the changes you are making and what each dotnetup mode does.

We likely want to enhance the walkthrough further, but I felt this was a large positive net change for only needing a small code change, and the logic here will need to exist in any future walkthrough improvement anyways.

In addition, this makes it more clear for users to understand what files we are about to modify, and whether dotnetup will work at all (example: if they were on an unsupported shell we might still pick terminal mode without any warning.)

The only functional change is the messaging - no behavioral changes were added.

New examples:

Replacement mode (default on Win):
image(it also shows if the path is inferred from global.json)

Terminal mode (default on unix):
image

When you're on an unsupported shell:
image

Old Behavior:

image

@nagilson
nagilson marked this pull request as ready for review August 6, 2026 19:33
Copilot AI review requested due to automatic review settings August 6, 2026 19:33
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
2 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Comment thread src/Installer/dotnetup.Library/Strings.resx Outdated
Comment thread src/Installer/dotnetup.Library/Commands/Init/WalkthroughSummary.cs Outdated
Comment thread src/Installer/dotnetup.Library/Commands/Init/WalkthroughSummary.cs
Comment thread src/Installer/dotnetup.Library/Commands/Init/WalkthroughSummary.cs
nagilson and others added 2 commits August 6, 2026 12:46
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

nagilson and others added 2 commits August 6, 2026 15:16
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@nagilson
nagilson requested review from a team, baronfel and dsplaisted August 6, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants