Show modified shell in dotnetup to explain modes - #55648
Open
nagilson wants to merge 8 commits into
Open
Conversation
…, DOTNET_ROOT, and profile locations
nagilson
marked this pull request as ready for review
August 6, 2026 19:33
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
1 similar comment
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
nagilson
commented
Aug 6, 2026
nagilson
commented
Aug 6, 2026
nagilson
commented
Aug 6, 2026
nagilson
commented
Aug 6, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this is not a complete resolution of #53963 (comment), (it does not fix the UX for 'env' commands), it does change the summary walkthrough to be more clear about the changes you are making and what each
dotnetupmodedoes.We likely want to enhance the walkthrough further, but I felt this was a large positive net change for only needing a small code change, and the logic here will need to exist in any future walkthrough improvement anyways.
In addition, this makes it more clear for users to understand what files we are about to modify, and whether
dotnetupwill work at all (example: if they were on an unsupported shell we might still pick terminal mode without any warning.)The only functional change is the messaging - no behavioral changes were added.
New examples:
Replacement mode (default on Win):
(it also shows if the path is inferred from global.json)
Terminal mode (default on unix):

When you're on an unsupported shell:

Old Behavior: